<html>
<head><meta charset="utf-8"><title>Why use `register_removed` for lints uplifted to rustc? · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html">Why use `register_removed` for lints uplifted to rustc?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="233821070"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233821070" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233821070">(Apr 09 2021 at 13:32)</a>:</h4>
<p>I just came across this code:</p>
<div class="codehilite" data-code-language="Rust"><pre><span></span><code><span class="w">    </span><span class="n">store</span><span class="p">.</span><span class="n">register_removed</span><span class="p">(</span><span class="w"></span>
<span class="w">        </span><span class="s">"clippy::temporary_cstring_as_ptr"</span><span class="p">,</span><span class="w"></span>
<span class="w">        </span><span class="s">"this lint has been uplifted to rustc and is now called `temporary_cstring_as_ptr`"</span><span class="p">,</span><span class="w"></span>
<span class="w">    </span><span class="p">);</span><span class="w"></span>
<span class="w">    </span><span class="n">store</span><span class="p">.</span><span class="n">register_removed</span><span class="p">(</span><span class="w"></span>
<span class="w">        </span><span class="s">"clippy::panic_params"</span><span class="p">,</span><span class="w"></span>
<span class="w">        </span><span class="s">"this lint has been uplifted to rustc and is now called `panic_fmt`"</span><span class="p">,</span><span class="w"></span>
<span class="w">    </span><span class="p">);</span><span class="w"></span>
</code></pre></div>
<p>Why does it use <code>register_removed</code> instead of <code>register_renamed</code>? register_renamed will also give a structured suggestion and apply the new lint even if you don't change the name in the code.</p>



<a name="233821105"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233821105" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233821105">(Apr 09 2021 at 13:32)</a>:</h4>
<p>happy to make a PR fixing it if you're interested :)</p>



<a name="233822383"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233822383" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233822383">(Apr 09 2021 at 13:41)</a>:</h4>
<p>I think because no one has asked this question before, so we just did it like this, because someone started to do it like this (Was it me? <a href="https://github.com/rust-lang/rust-clippy/commit/08fd397c2c8db452692dc71ce7b4d3c47417ff09">Who knows?</a>).</p>
<p>Using <code>register_renamed</code> definitely makes more sense here.</p>



<a name="233822413"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233822413" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233822413">(Apr 09 2021 at 13:41)</a>:</h4>
<p>haha, can do :)</p>



<a name="233822593"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233822593" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233822593">(Apr 09 2021 at 13:42)</a>:</h4>
<p>oh huh is this autogenerated?</p>
<div class="codehilite"><pre><span></span><code>/// Generates the `register_removed` code in `./clippy_lints/src/lib.rs`.
#[must_use]
pub fn gen_deprecated&lt;&#39;a&gt;(lints: impl Iterator&lt;Item = &amp;&#39;a Lint&gt;) -&gt; Vec&lt;String&gt; {
</code></pre></div>



<a name="233822898"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233822898" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233822898">(Apr 09 2021 at 13:44)</a>:</h4>
<p>Yes it is. It is generated from the lints in <code>clippy_lints/src/deprecated.rs</code>. Just remove the lints from there, add them as <code>registered_renamed</code> and run <code>cargo dev update_lints</code></p>



<a name="233822968"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233822968" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233822968">(Apr 09 2021 at 13:44)</a>:</h4>
<p>(I assume you mean <code>deprecated_lints.rs</code> and not <code>tests/ui/deprecated.rs</code>)</p>



<a name="233822976"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233822976" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233822976">(Apr 09 2021 at 13:44)</a>:</h4>
<p>You will have to fix/move some UI tests too.</p>



<a name="233823031"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233823031" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233823031">(Apr 09 2021 at 13:45)</a>:</h4>
<p>this makes sense why you keep handing people patches then, because clippy dev doesn't work in rust-lang/rust</p>



<a name="233823188"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233823188" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233823188">(Apr 09 2021 at 13:46)</a>:</h4>
<p>Yes, <a href="https://github.com/rust-lang/rust-clippy/blob/master/clippy_lints/src/deprecated_lints.rs">deprecated_lints.rs</a></p>



<a name="233823413"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233823413" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233823413">(Apr 09 2021 at 13:47)</a>:</h4>
<p>It does, if you add the <code>clippy_dev</code> dir as a workspace member to the <code>Cargo.toml</code> in the rust repo and then run <code>cargo dev</code> in the Clippy directory inside the Rust repo. But I still haven't implemented a <code>cargo dev uplift</code> (or similar) command...</p>



<a name="233823606"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233823606" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233823606">(Apr 09 2021 at 13:48)</a>:</h4>
<p><span class="user-mention silent" data-user-id="264664">flip1995</span> <a href="#narrow/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F/near/233822898">said</a>:</p>
<blockquote>
<p>Yes it is. It is generated from the lints in <code>clippy_lints/src/deprecated.rs</code>. Just remove the lints from there, add them as <code>registered_renamed</code> and run <code>cargo dev update_lints</code></p>
</blockquote>
<p>I'm actually considering adding a toggle to <code>deprecated.rs</code> so that they can still be autogenerated, that seems easier when uplifting lints</p>



<a name="233823642"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233823642" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233823642">(Apr 09 2021 at 13:48)</a>:</h4>
<p>although I guess running <code>clippy_dev</code> is annoying from rust-lang/rust, so maybe not worth it</p>



<a name="233824338"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233824338" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233824338">(Apr 09 2021 at 13:53)</a>:</h4>
<p>Since there is some more work involved than just adding the <code>register_removed</code> call, I don't think auto-generating this with <code>update_lints</code> helps much. If we want to automate this, it has to be done in its own <code>clippy_dev</code> command.</p>



<a name="233827585"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233827585" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233827585">(Apr 09 2021 at 14:12)</a>:</h4>
<p>hmm, the tests fail even without my changes</p>
<div class="codehilite"><pre><span></span><code>---- compile_test stdout ----
thread &#39;compile_test&#39; panicked at &#39;Found multiple rlibs for crate `regex`: `&quot;/home/joshua/.local/lib/cargo/target/debug/deps/libregex-d2621ea84e71e1fd.rlib&quot;` and `&quot;/home/joshua/.local/lib/cargo/target/debug/deps/libregex-ce97d2b47eb2018b.rlib&quot;&#39;, tests/compile-test.rs:51:25
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
</code></pre></div>



<a name="233828221"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233828221" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233828221">(Apr 09 2021 at 14:16)</a>:</h4>
<p>I think compiletest doesn't like that the target directory for clippy and tests is shared</p>



<a name="233828246"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233828246" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233828246">(Apr 09 2021 at 14:16)</a>:</h4>
<p><code>cargo clean</code> and rebuild should solve this.</p>



<a name="233828311"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233828311" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233828311">(Apr 09 2021 at 14:16)</a>:</h4>
<p>Yeah, we never managed to fix this...</p>



<a name="233828418"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233828418" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233828418">(Apr 09 2021 at 14:17)</a>:</h4>
<p><span class="user-mention silent" data-user-id="264664">flip1995</span> <a href="#narrow/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F/near/233828246">said</a>:</p>
<blockquote>
<p><code>cargo clean</code> and rebuild should solve this.</p>
</blockquote>
<p>nope, it regenerated the same regex artifacts on a rebuild</p>



<a name="233828445"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233828445" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233828445">(Apr 09 2021 at 14:17)</a>:</h4>
<p>but I unset CARGO_TARGET_DIR and I have hope it will work now :)</p>



<a name="233829940"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233829940" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233829940">(Apr 09 2021 at 14:27)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span> is there a way to run only a single compiletest test?</p>



<a name="233830010"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233830010" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233830010">(Apr 09 2021 at 14:27)</a>:</h4>
<p><code>TESTNAME=&lt;name-NOT-path&gt; cargo uitest</code></p>



<a name="233830172"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233830172" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233830172">(Apr 09 2021 at 14:28)</a>:</h4>
<p>(rustc is unhappy: <code>thread 'rustc' panicked at 'clippy_lints/src/lib.rs:2137:8: invalid lint renaming of clippy::panic_params to panic_fmt', /rustc/361bfce305b8829eda7f3d133fe82a118685de1f/library/std/src/panic.rs:59:5</code>)</p>



<a name="233830376"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233830376" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233830376">(Apr 09 2021 at 14:29)</a>:</h4>
<p>aha, it's non_panic_fmt now</p>



<a name="233830525"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233830525" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233830525">(Apr 09 2021 at 14:30)</a>:</h4>
<p>oof clippy-driver uses like all my memory to compile</p>



<a name="233830541"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233830541" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233830541">(Apr 09 2021 at 14:30)</a>:</h4>
<p>literally firefox locks up lol</p>



<a name="233831500"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233831500" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233831500">(Apr 09 2021 at 14:35)</a>:</h4>
<p>hmm, the tests pass but the stderr files didn't update?</p>



<a name="233831661"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233831661" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233831661">(Apr 09 2021 at 14:36)</a>:</h4>
<p>is there a way to run the clippy outside of the test suite? <code>target/debug/clippy-driver</code> says rustc_driver isn't found</p>



<a name="233831805"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233831805" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233831805">(Apr 09 2021 at 14:36)</a>:</h4>
<p><code>LD_LIBRARY_PATH=/home/joshua/.local/lib/rustup/toolchains/nightly-2021-04-08-x86_64-unknown-linux-gnu/lib</code> works</p>



<a name="233831982"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233831982" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233831982">(Apr 09 2021 at 14:37)</a>:</h4>
<p>yeah these definitely don't match:</p>
<div class="codehilite"><pre><span></span><code>error: lint `clippy::temporary_cstring_as_ptr` has been removed: this lint has been uplifted to rustc and is now called `temporary_cstring_as_ptr`
  --&gt; $DIR/deprecated.rs:10:8
   |
LL | #[warn(clippy::temporary_cstring_as_ptr)]
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
</code></pre></div>
<div class="codehilite"><pre><span></span><code>warning: lint `clippy::temporary_cstring_as_ptr` has been renamed to `temporary_cstring_as_ptr`
  --&gt; tests/ui/deprecated.rs:10:8
   |
10 | #[warn(clippy::temporary_cstring_as_ptr)]
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `temporary_cstring_as_ptr`
</code></pre></div>



<a name="233832073"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233832073" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233832073">(Apr 09 2021 at 14:38)</a>:</h4>
<p>oh because I still had TESTNAME lol</p>



<a name="233832265"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233832265" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233832265">(Apr 09 2021 at 14:39)</a>:</h4>
<p>is there a way to bless stderr? I don't see it in <a href="https://github.com/rust-lang/rust-clippy/blob/master/CONTRIBUTING.md">https://github.com/rust-lang/rust-clippy/blob/master/CONTRIBUTING.md</a></p>



<a name="233832390"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233832390" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233832390">(Apr 09 2021 at 14:40)</a>:</h4>
<p>aha, <code>cargo dev bless</code></p>



<a name="233832812"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233832812" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233832812">(Apr 09 2021 at 14:42)</a>:</h4>
<p>hmm now that I think about it I think most of the deprecated lints could use register_renamed too</p>



<a name="233832882"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233832882" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233832882">(Apr 09 2021 at 14:42)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span> do you want me to change them too while I'm at it?</p>



<a name="233832982"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233832982" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233832982">(Apr 09 2021 at 14:43)</a>:</h4>
<p>oh err never mind I got the lints in <code>deprecated_lints</code> mixed up with the ones in <a href="http://lib.rs">lib.rs</a></p>



<a name="233832986"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233832986" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233832986">(Apr 09 2021 at 14:43)</a>:</h4>
<p>lots of lints <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="233833297"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233833297" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233833297">(Apr 09 2021 at 14:45)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust-clippy/pull/7056">https://github.com/rust-lang/rust-clippy/pull/7056</a></p>



<a name="233833348"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233833348" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233833348">(Apr 09 2021 at 14:45)</a>:</h4>
<p>Oh, I missed your messages. Glad you figured out how it works on your own. (I think all your questions are documented <em>$somewhere</em>).</p>
<p>Feel free to move lints to <code>renamed</code> as you see fit.</p>



<a name="233833567"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233833567" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233833567">(Apr 09 2021 at 14:46)</a>:</h4>
<p>no problem, I tend to ramble <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="233833625"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233833625" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233833625">(Apr 09 2021 at 14:47)</a>:</h4>
<p>you should have seen my nonsense when I was adding <a href="https://github.com/rust-lang/rust/pull/79540">https://github.com/rust-lang/rust/pull/79540</a></p>



<a name="233834319"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233834319" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233834319">(Apr 09 2021 at 14:51)</a>:</h4>
<p>hmm these seem like real regressions? They were removed by <code>clippy dev update_lints</code></p>
<div class="codehilite"><pre><span></span><code>CHANGELOG.md
     182:3-182:27  warning  Found reference to undefined definition  no-undefined-references  remark-lint
    283:13-283:29  warning  Found reference to undefined definition  no-undefined-references  remark-lint
    422:13-422:28  warning  Found reference to undefined definition  no-undefined-references  remark-lint
  1021:13-1021:29  warning  Found reference to undefined definition  no-undefined-references  remark-lint
   1049:3-1049:27  warning  Found reference to undefined definition  no-undefined-references  remark-lint
  1083:13-1083:35  warning  Found reference to undefined definition  no-undefined-references  remark-lint
  1285:13-1285:28  warning  Found reference to undefined definition  no-undefined-references  remark-lint
  1378:25-1378:47  warning  Found reference to undefined definition  no-undefined-references  remark-lint
  1652:78-1652:93  warning  Found reference to undefined definition  no-undefined-references  remark-lint
  2040:14-2040:42  warning  Found reference to undefined definition  no-undefined-references  remark-lint
  2094:46-2094:62  warning  Found reference to undefined definition  no-undefined-references  remark-lint
</code></pre></div>



<a name="233834435"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233834435" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233834435">(Apr 09 2021 at 14:51)</a>:</h4>
<p>not sure what I should do, I think if I add them back update_lints will just remove them again</p>



<a name="233835510"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Why%20use%20%60register_removed%60%20for%20lints%20uplifted%20to%20rustc%3F/near/233835510" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Why.20use.20.60register_removed.60.20for.20lints.20uplifted.20to.20rustc.3F.html#233835510">(Apr 09 2021 at 14:58)</a>:</h4>
<p>now back to uplifting invalid_atomic_ordering <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>